Add Validator Gossiper #2015
Merged
Add Validator Gossiper #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
danlaine and
StephenButtolph
as code owners
joshua-kim
force-pushed
the
validator-gossiper
branch
from
5219416
to
8119600
Compare
StephenButtolph
approved these changes
Sep 13, 2023
dhrubabasu
approved these changes
Sep 13, 2023
StephenButtolph
added
networking
| } | ||
|
|
||
| func (v ValidatorGossiper) Gossip(ctx context.Context) error { | ||
| if !v.Validators.Has(ctx, v.NodeID) { |
There was a problem hiding this comment.
This does not interfere with push gossip that may otherwise be going on, right?
There was a problem hiding this comment.
The bloom filter gossip stuff is sandboxed in its own implementation so it runs in parallel to the existing push gossip. The push gossip stuff also doesn't implement the Gossiper interface so it shouldn't ever be affected by this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We currently throttle inbound requests for our tx gossip, so it doesn't make sense for us to request gossip if we're not a current validator.
How this works
GossipertoPullGossiperGossiperinterface since we now have multipleGossiperimplementations.ValidatorGossiperthat only gossips if we are a valdiator.How this was tested
Added a unit test