merkledb -- encode lengths as uvarints
#2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2023 09:58
danlaine
changed the title
merkledb -- encode lengths as uint64merkledb -- encode lengths as uvarints
richardpringle
approved these changes
Sep 19, 2023
danlaine
commented
Sep 19, 2023
| @@ -221,18 +220,15 @@ func (*codecImpl) decodeBool(src *bytes.Reader) (bool, error) { | |||
| } | |||
| } | |||
|
|
|||
| func (c *codecImpl) encodeInt(dst *bytes.Buffer, value int) { | |||
There was a problem hiding this comment.
We only encode non-negative ints so this was replaced with encodeUint64
danlaine
commented
Sep 19, 2023
x/merkledb/codec.go
Outdated
|
|
||
| func (*codecImpl) decodeInt(src *bytes.Reader) (int, error) { | ||
| // decodeUint decodes a uvarint from [src] and returns it as an int. | ||
| func (*codecImpl) decodeUint(src *bytes.Reader) (int, error) { |
There was a problem hiding this comment.
Arguably this should return a uint but a bunch of places where we use this, we want it as an int, so idk
There was a problem hiding this comment.
do we want to just update all of those variables to be uints instead?
dboehm-avalabs
approved these changes
Sep 19, 2023
danlaine
commented
Sep 19, 2023
| c.encodeInt64(dst, int64(value)) | ||
| } | ||
|
|
||
| func (*codecImpl) decodeInt(src *bytes.Reader) (int, error) { |
There was a problem hiding this comment.
Changed to decodeUint since we always read uint64s
added 4 commits
September 19, 2023 11:57
… into merkledb-codec-unit
xinifinity
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
These lengths can never be negative.
How this works
Varint-->UvarintHow this was tested
Existing UT