Update perms.WriteFile to write atomically #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
atomic-write-file
branch
from
2ff37c3
to
24435e7
Compare
marun
changed the title
marun
force-pushed
the
atomic-write-file
branch
from
5b660d0
to
a998c24
Compare
StephenButtolph
approved these changes
Sep 22, 2023
dhrubabasu
approved these changes
Sep 22, 2023
patrick-ogrady
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This ensures that files are written atomically to avoid readers from reading partial files. There have been recent flakes caused by the process context file not being written completely before being read by the testnet fixture.
How this works
perms.WriteFileto write files atomically with renameio.WriteFileperms.WriteFileHow this was tested
CI