Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove embedding of verify.Verifiable in FxCredential #2089

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Remove embedding of verify.Verifiable in FxCredential #2089

merged 2 commits into from
Sep 26, 2023

Conversation

dhrubabasu
Copy link
Contributor

Why this should be merged

Embedding verify.Verifiable in a struct seems strange. We now use Credential instead to better tag the field.

How this works

pretty straightforward

How this was tested

CI

@dhrubabasu dhrubabasu added the cleanup Code quality improvement label Sep 23, 2023
@dhrubabasu dhrubabasu added this to the v1.10.12 milestone Sep 23, 2023
@dhrubabasu dhrubabasu self-assigned this Sep 23, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 26, 2023
Merged via the queue into dev with commit c20fbc5 Sep 26, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the dont-embed-verifiable branch September 26, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlaine danlaine danlaine approved these changes

@StephenButtolph StephenButtolph StephenButtolph approved these changes

Assignees

@dhrubabasu dhrubabasu

Labels
cleanup Code quality improvement
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.12
Development

Successfully merging this pull request may close these issues.
3 participants
@dhrubabasu @danlaine @StephenButtolph