Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify decidable interface simple default parameter tests #2094

Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 25, 2023

Why this should be merged

Took me a while to figure out my consensus example was crashing because of my wrong block implementation. Would like to highlight such implementation details in the interface doc. And adding some basic example.

How this works

N/A

How this was tested

N/A

…eter tests

Co-authored-by: Stephen Buttolph <stephen@avalabs.org>

Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
@gyuho gyuho changed the base branch from master to dev September 25, 2023 03:45
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Sep 26, 2023
@StephenButtolph StephenButtolph added documentation Improvements or additions to documentation or examples consensus This involves consensus labels Sep 26, 2023
snow/choices/decidable.go Outdated Show resolved Hide resolved
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 26, 2023
Merged via the queue into dev with commit 9101a8e Sep 26, 2023
16 checks passed
@StephenButtolph StephenButtolph deleted the clarify-decidable-interface-simple-default-parameter-tests branch September 26, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus This involves consensus documentation Improvements or additions to documentation or examples
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants