Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of wg in the networking dial test #2132

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix handling of wg in the networking dial test #2132

merged 1 commit into from
Oct 3, 2023

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

Fixes a flaky test

How this works

We were calling wg.Done rather than wg.Wait

How this was tested

CI

@StephenButtolph StephenButtolph added bug Something isn't working testing This primarily focuses on testing networking This involves networking labels Oct 3, 2023
@StephenButtolph StephenButtolph added this to the v1.10.12 milestone Oct 3, 2023
@StephenButtolph StephenButtolph self-assigned this Oct 3, 2023
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 3, 2023
Merged via the queue into dev with commit 0022f37 Oct 3, 2023
15 checks passed
@StephenButtolph StephenButtolph deleted the fix-networking-dial-test branch October 3, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hexfusion hexfusion hexfusion approved these changes

@joshua-kim joshua-kim joshua-kim approved these changes

@danlaine danlaine Awaiting requested review from danlaine

Assignees

@StephenButtolph StephenButtolph

Labels
bug Something isn't working networking This involves networking testing This primarily focuses on testing
Projects
No open projects
Ski Patrol
Archived in project
Milestone
v1.10.12
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @hexfusion @joshua-kim