Ensure upgrade test uses the correct binary on restart #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
fix-upgrade-test
branch
9 times, most recently
from
2dceb65
to
e208e87
Compare
Also: - Fix upgrade test workflow to target the correct path for artifact upload - Ensure all tmpnet artifact upload reports an error if files are missing
marun
force-pushed
the
fix-upgrade-test
branch
from
e208e87
to
5d5df8d
Compare
StephenButtolph
approved these changes
Dec 13, 2023
dhrubabasu
approved these changes
Dec 13, 2023
aaronbuchwald
approved these changes
Dec 13, 2023
Comment on lines
+14
to
+17
| # 1.10.17 is the first version compatible with bls signing keys being | ||
| # included in the genesis. Attempting to upgrade from prior versions | ||
| # will result in nodes failing to boot due to the hash of the genesis | ||
| # not matching the hash of the committed genesis block. |
There was a problem hiding this comment.
Suggested change
| # 1.10.17 is the first version compatible with bls signing keys being | |
| # included in the genesis. Attempting to upgrade from prior versions | |
| # will result in nodes failing to boot due to the hash of the genesis | |
| # not matching the hash of the committed genesis block. | |
| # The AvalancheGo local network does not support long-lived backwards | |
| # compatible networks. When a breaking change is made to the local | |
| # network, this flag must be updated to the last compatible version | |
| # with the latest code. | |
| # v1.10.17 includes the AWM activation on the C-Chain local network | |
| # and the inclusion of BLS Public Keys in the network genesis. |
marun
added a commit
that referenced
this pull request
Dec 20, 2023
marun
added a commit
that referenced
this pull request
Dec 21, 2023
marun
added a commit
that referenced
this pull request
Dec 22, 2023
marun
added a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Fix upgrade test workflow to target the correct path for artifact upload
Ensure all tmpnet artifact upload reports an error if files are missing
Move the default upgrade version in the tests.upgrade.sh to simplify local execution (no longer have to provide a compatible version to the script)