-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bloom filter metrics to the p2p sdk #2612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
added
the
monitoring
This primarily focuses on logs, metrics, and/or tracing
label
Jan 16, 2024
ceyonur
requested review from
abi87,
danlaine,
dhrubabasu,
StephenButtolph and
joshua-kim
as code owners
January 16, 2024 11:27
darioush
approved these changes
Jan 16, 2024
joshua-kim
reviewed
Jan 17, 2024
StephenButtolph
changed the title
add bloom filter metrics
Add bloom filter metrics to the p2p sdk
Jan 19, 2024
joshua-kim
approved these changes
Jan 19, 2024
StephenButtolph
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds bloom filter metrics. Currently only reset count is tracked.
Closes: ava-labs/coreth#454
How this works
NewBloomFilter
takes registerer as input and creates metrics.How this was tested
Added UT.
P-chain:
X-chain:
C-chain: