Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics namespace #2632

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix metrics namespace #2632

merged 2 commits into from
Jan 19, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Jan 19, 2024 •
edited
Loading

Why this should be merged

Currently there are a few places were we incorrectly handle empty namespaces. Specifically, if the namespace is empty, we should not prefix the resulting namespace with a _.

How this works

  • Refactors the code handling this from the api/metrics package into a helper function
  • Uses the helper function wherever we add namespacing

How this was tested

  • New unit tests

@StephenButtolph StephenButtolph added monitoring This primarily focuses on logs, metrics, and/or tracing cleanup Code quality improvement labels Jan 19, 2024
@StephenButtolph StephenButtolph added this to the v1.10.19 milestone Jan 19, 2024
@StephenButtolph StephenButtolph self-assigned this Jan 19, 2024
@StephenButtolph StephenButtolph mentioned this pull request Jan 19, 2024
Merged
2 tasks
@StephenButtolph StephenButtolph added this pull request to the merge queue Jan 19, 2024
Merged via the queue into master with commit 18cdb09 Jan 19, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the fix-metrics-namespace branch January 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun marun approved these changes

@dhrubabasu dhrubabasu dhrubabasu approved these changes

@abi87 abi87 Awaiting requested review from abi87

@danlaine danlaine Awaiting requested review from danlaine

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs

@gyuho gyuho Awaiting requested review from gyuho

Assignees

@StephenButtolph StephenButtolph

Labels
cleanup Code quality improvement monitoring This primarily focuses on logs, metrics, and/or tracing
Projects
Platform Engineering Group
Archived in project
Milestone
v1.10.19
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @marun @dhrubabasu