ci: Add shellcheck step to lint job
#2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
ci-shellcheck
branch
4 times, most recently
from
e8ad336
to
afdd091
Compare
marun
commented
Jan 23, 2024
| if [[ "${SYSTEM_VERSION}" == "${VERSION}" ]]; then | ||
| SHELLCHECK=shellcheck | ||
| else | ||
| SHELLCHECK="${REPO_ROOT}/build/shellcheck" |
There was a problem hiding this comment.
Not entirely convinced this is the best location. I'm also not a huge fan of running directly from /tmp (as per ANR). Suggested alternatives?
There was a problem hiding this comment.
I think build is reasonable... It's where we put the rest of our binaries right now... and it's ignored accordingly already
| @@ -60,4 +60,4 @@ fi | |||
|
|
|||
| ################################# | |||
| # - Execute in random order to identify unwanted dependency | |||
| ginkgo -p -v --randomize-all ./tests/e2e/e2e.test -- ${E2E_ARGS} "${@}" | |||
| ginkgo ${GINKGO_ARGS} -v --randomize-all ./tests/e2e/e2e.test -- "${E2E_ARGS[@]}" "${@}" | |||
There was a problem hiding this comment.
This is a fix right? previously we just always ran in parallel right?
There was a problem hiding this comment.
Yes, I tried to make the parallelism conditional but failed :/
Though maybe this is no longer required due to using a smaller shared network (2 vs 5 nodes)?
StephenButtolph
approved these changes
Jan 23, 2024
StephenButtolph
added
testing
dhrubabasu
approved these changes
Jan 23, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#lintallthethings!
We lint code, why not shell scripts? In addition to simplifying the avoidance of common shell errors, the shellcheck wiki has lots of documentation for all the error types it checks for.
Testing
In addition to CI, local testing on arm64 linux and macos verified the logic for downloading and using a local (vs a system-wide) shellcheck.