tmpnet: Ensure restart after chain creation
#2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
approved these changes
Jan 29, 2024
StephenButtolph
approved these changes
Jan 30, 2024
marun
added a commit
that referenced
this pull request
Feb 9, 2024
marun
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous iteration of tmpnet created subnets and chains, restarted nodes, and then added validators. This was changed to create subnets, restart nodes, add validators, and create chains. This prevented the correct configuration of any chain that had explicit configuration since the configuration would only be written after the chain was created and nodes need to be restarted to see the new configuration.
So, nodes are now restarted if any chains have explicit configuration.
Restart will be tested in ava-labs/subnet-evm#1027