Unblock misconfigured subnets #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Jan 30, 2024
| @@ -171,7 +171,7 @@ func (t *Transitive) Gossip(ctx context.Context) error { | |||
| // nodes with a large amount of stake weight. | |||
| vdrID, ok := t.ConnectedValidators.SampleValidator() | |||
| if !ok { | |||
| t.Ctx.Log.Error("skipping block gossip", | |||
| t.Ctx.Log.Warn("skipping block gossip", | |||
There was a problem hiding this comment.
These are no longer Errors as the node can recover.
| @@ -932,7 +937,7 @@ func (t *Transitive) sendQuery( | |||
|
|
|||
| vdrIDs, err := t.Validators.Sample(t.Ctx.SubnetID, t.Params.K) | |||
| if err != nil { | |||
| t.Ctx.Log.Error("dropped query for block", | |||
| t.Ctx.Log.Warn("dropped query for block", | |||
There was a problem hiding this comment.
These are no longer Errors as the node can recover.
marun
approved these changes
Jan 30, 2024
| @@ -2921,3 +2921,108 @@ func TestEngineApplyAcceptedFrontierInQueryFailed(t *testing.T) { | |||
|
|
|||
| require.Equal(choices.Accepted, blk.Status()) | |||
| } | |||
|
|
|||
| func TestEngineRepollsMisconfiguredSubnet(t *testing.T) { | |||
There was a problem hiding this comment.
(No action required) I was able to grok this test, but have some suggestions for increasing maintainability:
- separate out setup (either to helper function(s) or delineated with e.g. comments) from test
- use comments to highlight important parts of the test that might not be immediately obvious to the uninitiated e.g.
- create subnet that is misconfigured (missing validator?)
- check that a tx won't be committed
- fix misconfiguration
- check that new tx can be commited (what about previous tx?)
There was a problem hiding this comment.
I added comments. I'm hoping to do a large refactor of both this code and the tests... When we do that hopefully all of this will be able to be cleaned up.
dhrubabasu
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #2594. While this is an unsafe/undesirable configuration. This error has occurred enough that we should probably make it at least recoverable. Especially for users that have no control over the validator set (which can occur on permissioned subnets)
How this works
If there a blocks processing, we now trigger repolls during the periodic
Gossipcall. This gets the node out of the (generally unexpected) state where there are blocks processing but there are no outstanding polls.How this was tested