Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker images with race detection #2680

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Jan 30, 2024

Why this should be merged

Enables users to run avalanchego with race detection enabled inside of docker.

How this works

  • Allows passing in the -r flag to scripts/build.sh from the dockerfile
  • Publishes a second docker image with the same name suffixed by -race
  • Errors if the name of the branch ends in -race (to prevent confusion)

How this was tested

@StephenButtolph StephenButtolph added this to the v1.10.20 milestone Jan 30, 2024
@StephenButtolph StephenButtolph added the ci This focuses on changes to the CI process label Jan 30, 2024
@StephenButtolph StephenButtolph self-assigned this Jan 30, 2024
@StephenButtolph StephenButtolph marked this pull request as ready for review January 30, 2024 19:48
@StephenButtolph StephenButtolph merged commit e6a3a91 into master Jan 30, 2024
17 checks passed
@StephenButtolph StephenButtolph deleted the publish-race-dockerimage branch January 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants