Add platform.getSubnet API
#2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
abi87,
danlaine,
dhrubabasu and
StephenButtolph
as code owners
felipemadero
changed the title
felipemadero
changed the title
felipemadero
changed the title
|
Can we make a corresponding PR to update the docs with this new method? |
here it is: |
@StephenButtolph @danlaine addressed your comments |
|
just nits then lgtm |
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: felipemadero <felipe.madero@gmail.com>
abi87
reviewed
Feb 8, 2024
StephenButtolph
approved these changes
Feb 10, 2024
StephenButtolph
changed the title
platform.getSubnet API
abi87
approved these changes
Feb 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There is no API related way to get subnet information such as transform subnet tx id, or updated owners
How this works
It adds a new API call and client method, GetSubnet
How this was tested
Tested on CLI branch developed to change subnet owners.