Remove duplicate IP length constant #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
danlaine and
joshua-kim
as code owners
joshua-kim
approved these changes
Feb 13, 2024
dhrubabasu
approved these changes
Feb 13, 2024
abi87
added a commit
that referenced
this pull request
Feb 15, 2024
commit cb0a693 Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Thu Feb 15 12:16:10 2024 +0100 replaced Spend with NewSpend commit 03c0a9f Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Thu Feb 15 11:50:01 2024 +0100 wip: refactoring importTx builder commit 40e480a Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Thu Feb 15 11:02:53 2024 +0100 refactored exportTx builder commit 7c04d76 Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Wed Feb 14 18:46:20 2024 +0100 refactored operationTx builder commit 39cae3c Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Wed Feb 14 17:48:17 2024 +0100 refactored baseTx builder commit 1feae9a Author: Alberto Benegiamo <alberto.benegiamo@gmail.com> Date: Wed Feb 14 15:55:07 2024 +0100 refactored createAssetTx builder commit a759c24 Author: Stephen Buttolph <stephen@avalabs.org> Date: Tue Feb 13 15:21:03 2024 -0500 Remove duplicate IP length constant (#2733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This constant was defined twice (with a magic number).
How this works
Removes one of the definitions and both of the magic numbers
How this was tested