X-chain wallet fees UTs #2747
Merged
X-chain wallet fees UTs #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
abi87
force-pushed
the
x-chain-wallet-UTs
branch
from
6da6689
to
6c55d1c
Compare
abi87
force-pushed
the
x-chain-wallet-UTs
branch
from
6c55d1c
to
86e9d94
Compare
dhrubabasu
reviewed
Feb 19, 2024
|
one comment about duplicate code, other than that lgtm |
StephenButtolph
approved these changes
Feb 19, 2024
dhrubabasu
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Even before introduction of dynamic fees over the X-chain, we can really use some unit tests that make sure that X-chain wallet spends enough to pay transactions fees and no more.
Similar to what we did in #2734
How this works
Added UTs
How this was tested
Just added tests.