-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vms/platformvm] Use wallet
sdk in txstest.Builder
#2751
Merged
Merged
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
f5ff8d6
spend cleanup
abi87 26a9e31
Merge branch 'master' into p-chain_spend_cleanup
abi87 7f594ea
repackaged signer from wallet to pchain txs subpackage
abi87 89da2ba
introduced wallet signer visitor in pchain txs builder subpackage
abi87 e26bec9
drop signers from utxos.Spend handler
abi87 dd17dbb
moved wallet builder backend to pchain
abi87 0904787
some more repackaging
abi87 2087443
wip: chaining p-chain txbuilder with wallet builder and signer
abi87 2ef66ea
nit
abi87 0cd2d7e
Merge branch 'master' into p-chain_spend_cleanup
abi87 95d64cc
wip: some more chaining p-chain txbuilder with wallet builder and signer
abi87 131c198
txbuilder constructor cleanup
abi87 979e30d
removed utxos Spend and Authorize
abi87 566b09b
moved backends package to wallet
abi87 1b22091
nit
abi87 f7d288c
nits
abi87 fa0eb5a
repackaged wallet backend for P-chain
abi87 4405a2e
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 480fb45
consolidated backend implementation
abi87 30498e7
some more cleanup
abi87 1881282
nits
abi87 fca9d28
fixed create chain tx fee
abi87 0f24a1a
fixed UTs
abi87 ba8e792
Merge branch 'master' into p-chain_wallet_backends
abi87 d2d6aec
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 5aa5932
some more fixes
abi87 20a7c41
Merge branch 'p-chain_spend_cleanup' of github.com:ava-labs/avalanche…
abi87 3b6b5f5
Merge branch 'master' into p-chain_wallet_backends
abi87 655e402
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 ebc1b50
minor renaming
abi87 952ed47
Merge branch 'master' into p-chain_wallet_backends
abi87 c050a42
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 2aa4b70
Merge branch 'master' into p-chain_wallet_backends
abi87 4b47e03
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 4aedae5
Merge branch 'master' into p-chain_wallet_backends
abi87 a92b693
Merge branch 'master' into p-chain_wallet_backends
abi87 e418d7e
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 f1e5a44
Merge branch 'master' into p-chain_wallet_backends
abi87 0d5a1af
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 08def6a
Merge branch 'master' into p-chain_wallet_backends
abi87 e9860dc
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 b01a2d2
Merge branch 'master' into p-chain_wallet_backends
abi87 eb59fda
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 a56a753
Merge branch 'master' into p-chain_wallet_backends
abi87 2039a84
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 4c5787e
Merge branch 'master' into p-chain_wallet_backends
abi87 a581616
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 9ac3a33
Merge branch 'master' into p-chain_wallet_backends
abi87 2c3f2a5
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 16cf7c4
cleanup
StephenButtolph 51729d9
nit
StephenButtolph 6772d28
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph 9481ff7
nit
StephenButtolph ade5178
fix merge
StephenButtolph ba48394
nit
StephenButtolph c6f7143
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph 6de663b
save
StephenButtolph 6c9004d
nit
StephenButtolph 318be91
nit
StephenButtolph 41f1405
nit
StephenButtolph edbfd16
nit
StephenButtolph bc5b5e0
nit
StephenButtolph 264706d
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph b2d11ce
nit
StephenButtolph ff6f721
Merge branch 'master' into p-chain_spend_cleanup
abi87 48bd901
Merge branch 'master' into p-chain_spend_cleanup
abi87 79d8b2d
Merge branch 'master' into p-chain_spend_cleanup
abi87 fc5cc77
Merge branch 'master' into p-chain_spend_cleanup
abi87 064a486
Merge branch 'master' into p-chain_spend_cleanup
abi87 90456d5
Merge branch 'master' into p-chain_spend_cleanup
abi87 5d13597
nits (#2861)
dhrubabasu f45afe9
Merge branch 'master' into p-chain_spend_cleanup
abi87 f57a91a
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu 77be9e9
Merge branch 'master' into p-chain_spend_cleanup
abi87 d695437
nits (#2874)
dhrubabasu fe8c795
remove config from backend
dhrubabasu 3f7291f
nit
dhrubabasu 1cddffc
nit
dhrubabasu af093c9
nit
dhrubabasu b0ec09b
nit
dhrubabasu 4cb5f9e
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu 508d742
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu d8f04ba
Merge branch 'master' into p-chain_spend_cleanup
abi87 f8af011
nit to restore stakers order in UT
abi87 6fd25ec
nit
abi87 42b556d
nit
dhrubabasu 0d157f8
nits
dhrubabasu cd97be6
nit
dhrubabasu cd105df
`txstest`
dhrubabasu daeb16a
nit
dhrubabasu 5e2e788
reduce diff
dhrubabasu a0cc76b
nits
dhrubabasu 8c91bb3
nit
dhrubabasu 069cf17
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhrubabasu I believe we have to explicitly add the change addresses to avoid flaking here.
This UT is tricky because it tests a case where two stakers share the same end time.
The one evicted will be the one with the smallest TxID, which depends on every details of the transaction creating the staker.
If we don't declare the change address explicitly, any address from the funding keys will be picked. Since we have cases where multiple keys are specified, we have the randomness causing flaking.
The change address does not have to be empty, it can be anything fixed. I picked empty to try and signal the change address does not really matter (it's enough it does not change run by run).
I also added a comment to hopefully simplify maintenance.