Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vms/platformvm] Use wallet sdk in txstest.Builder #2751

Merged
merged 94 commits into from
Mar 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
f5ff8d6
spend cleanup
abi87 Feb 19, 2024
26a9e31
Merge branch 'master' into p-chain_spend_cleanup
abi87 Feb 19, 2024
7f594ea
repackaged signer from wallet to pchain txs subpackage
abi87 Feb 19, 2024
89da2ba
introduced wallet signer visitor in pchain txs builder subpackage
abi87 Feb 20, 2024
e26bec9
drop signers from utxos.Spend handler
abi87 Feb 20, 2024
dd17dbb
moved wallet builder backend to pchain
abi87 Feb 20, 2024
0904787
some more repackaging
abi87 Feb 20, 2024
2087443
wip: chaining p-chain txbuilder with wallet builder and signer
abi87 Feb 20, 2024
2ef66ea
nit
abi87 Feb 21, 2024
0cd2d7e
Merge branch 'master' into p-chain_spend_cleanup
abi87 Feb 21, 2024
95d64cc
wip: some more chaining p-chain txbuilder with wallet builder and signer
abi87 Feb 21, 2024
131c198
txbuilder constructor cleanup
abi87 Feb 21, 2024
979e30d
removed utxos Spend and Authorize
abi87 Feb 21, 2024
566b09b
moved backends package to wallet
abi87 Feb 21, 2024
1b22091
nit
abi87 Feb 21, 2024
f7d288c
nits
abi87 Feb 21, 2024
fa0eb5a
repackaged wallet backend for P-chain
abi87 Feb 21, 2024
4405a2e
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Feb 21, 2024
480fb45
consolidated backend implementation
abi87 Feb 21, 2024
30498e7
some more cleanup
abi87 Feb 21, 2024
1881282
nits
abi87 Feb 21, 2024
fca9d28
fixed create chain tx fee
abi87 Feb 21, 2024
0f24a1a
fixed UTs
abi87 Feb 21, 2024
ba8e792
Merge branch 'master' into p-chain_wallet_backends
abi87 Feb 22, 2024
d2d6aec
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Feb 22, 2024
5aa5932
some more fixes
abi87 Feb 22, 2024
20a7c41
Merge branch 'p-chain_spend_cleanup' of github.com:ava-labs/avalanche…
abi87 Feb 22, 2024
3b6b5f5
Merge branch 'master' into p-chain_wallet_backends
abi87 Feb 25, 2024
655e402
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Feb 25, 2024
ebc1b50
minor renaming
abi87 Feb 26, 2024
952ed47
Merge branch 'master' into p-chain_wallet_backends
abi87 Feb 29, 2024
c050a42
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Feb 29, 2024
2aa4b70
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 4, 2024
4b47e03
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 4, 2024
4aedae5
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 5, 2024
a92b693
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 6, 2024
e418d7e
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 6, 2024
f1e5a44
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 7, 2024
0d5a1af
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 7, 2024
08def6a
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 11, 2024
e9860dc
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 11, 2024
b01a2d2
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 11, 2024
eb59fda
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 11, 2024
a56a753
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 12, 2024
2039a84
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 12, 2024
4c5787e
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 13, 2024
a581616
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 13, 2024
9ac3a33
Merge branch 'master' into p-chain_wallet_backends
abi87 Mar 18, 2024
2c3f2a5
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
abi87 Mar 18, 2024
16cf7c4
cleanup
StephenButtolph Mar 18, 2024
51729d9
nit
StephenButtolph Mar 18, 2024
6772d28
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph Mar 18, 2024
9481ff7
nit
StephenButtolph Mar 19, 2024
ade5178
fix merge
StephenButtolph Mar 19, 2024
ba48394
nit
StephenButtolph Mar 19, 2024
c6f7143
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph Mar 19, 2024
6de663b
save
StephenButtolph Mar 19, 2024
6c9004d
nit
StephenButtolph Mar 19, 2024
318be91
nit
StephenButtolph Mar 19, 2024
41f1405
nit
StephenButtolph Mar 19, 2024
edbfd16
nit
StephenButtolph Mar 19, 2024
bc5b5e0
nit
StephenButtolph Mar 19, 2024
264706d
Merge branch 'p-chain_wallet_backends' into p-chain_spend_cleanup
StephenButtolph Mar 19, 2024
b2d11ce
nit
StephenButtolph Mar 19, 2024
ff6f721
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 19, 2024
48bd901
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 20, 2024
79d8b2d
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 21, 2024
fc5cc77
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 22, 2024
064a486
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 22, 2024
90456d5
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 25, 2024
5d13597
nits (#2861)
dhrubabasu Mar 25, 2024
f45afe9
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 26, 2024
f57a91a
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu Mar 26, 2024
77be9e9
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 27, 2024
d695437
nits (#2874)
dhrubabasu Mar 27, 2024
fe8c795
remove config from backend
dhrubabasu Mar 27, 2024
3f7291f
nit
dhrubabasu Mar 27, 2024
1cddffc
nit
dhrubabasu Mar 27, 2024
af093c9
nit
dhrubabasu Mar 27, 2024
b0ec09b
nit
dhrubabasu Mar 27, 2024
4cb5f9e
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu Mar 27, 2024
508d742
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu Mar 27, 2024
d8f04ba
Merge branch 'master' into p-chain_spend_cleanup
abi87 Mar 28, 2024
f8af011
nit to restore stakers order in UT
abi87 Mar 28, 2024
6fd25ec
nit
abi87 Mar 28, 2024
42b556d
nit
dhrubabasu Mar 28, 2024
0d157f8
nits
dhrubabasu Mar 28, 2024
cd97be6
nit
dhrubabasu Mar 28, 2024
cd105df
`txstest`
dhrubabasu Mar 28, 2024
daeb16a
nit
dhrubabasu Mar 28, 2024
5e2e788
reduce diff
dhrubabasu Mar 28, 2024
a0cc76b
nits
dhrubabasu Mar 28, 2024
8c91bb3
nit
dhrubabasu Mar 28, 2024
069cf17
Merge branch 'master' into p-chain_spend_cleanup
dhrubabasu Mar 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions vms/platformvm/block/executor/proposal_block_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import (
"github.com/ava-labs/avalanchego/vms/platformvm/txs"
"github.com/ava-labs/avalanchego/vms/platformvm/txs/executor"
"github.com/ava-labs/avalanchego/vms/secp256k1fx"

walletcommon "github.com/ava-labs/avalanchego/wallet/subnet/primary/common"
)

func TestApricotProposalBlockTimeVerification(t *testing.T) {
Expand Down Expand Up @@ -547,6 +549,10 @@ func TestBanffProposalBlockUpdateStakers(t *testing.T) {
},
reward.PercentDenominator,
[]*secp256k1.PrivateKey{preFundedKeys[0]},
walletcommon.WithChangeOwner(&secp256k1fx.OutputOwners{
Threshold: 1,
Addrs: []ids.ShortID{ids.ShortEmpty},
}),
)
require.NoError(err)

Expand All @@ -573,6 +579,10 @@ func TestBanffProposalBlockUpdateStakers(t *testing.T) {
Subnet: subnetID,
},
[]*secp256k1.PrivateKey{preFundedKeys[0], preFundedKeys[1]},
walletcommon.WithChangeOwner(&secp256k1fx.OutputOwners{
Threshold: 1,
Addrs: []ids.ShortID{ids.ShortEmpty},
}),
Comment on lines +583 to +586
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhrubabasu I believe we have to explicitly add the change addresses to avoid flaking here.
This UT is tricky because it tests a case where two stakers share the same end time.
The one evicted will be the one with the smallest TxID, which depends on every details of the transaction creating the staker.
If we don't declare the change address explicitly, any address from the funding keys will be picked. Since we have cases where multiple keys are specified, we have the randomness causing flaking.
The change address does not have to be empty, it can be anything fixed. I picked empty to try and signal the change address does not really matter (it's enough it does not change run by run).
I also added a comment to hopefully simplify maintenance.

)
require.NoError(err)

Expand Down Expand Up @@ -606,6 +616,10 @@ func TestBanffProposalBlockUpdateStakers(t *testing.T) {
},
reward.PercentDenominator,
[]*secp256k1.PrivateKey{preFundedKeys[0], preFundedKeys[1]},
walletcommon.WithChangeOwner(&secp256k1fx.OutputOwners{
Threshold: 1,
Addrs: []ids.ShortID{ids.ShortEmpty},
}),
)
require.NoError(err)

Expand Down Expand Up @@ -774,6 +788,10 @@ func TestBanffProposalBlockRemoveSubnetValidator(t *testing.T) {
},
reward.PercentDenominator,
[]*secp256k1.PrivateKey{preFundedKeys[0], preFundedKeys[1]},
walletcommon.WithChangeOwner(&secp256k1fx.OutputOwners{
Threshold: 1,
Addrs: []ids.ShortID{ids.ShortEmpty},
}),
)
require.NoError(err)

Expand Down
Loading