tmpnet: Write config enabling metrics collection by prometheus
#2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
added
testing
5 tasks
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
f9c51f9
to
3058261
Compare
marun
force-pushed
the
tmpnet-network-uuids
branch
from
812405e
to
7b96e9f
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
3058261
to
fdd36d2
Compare
marun
removed
the
monitoring
marun
force-pushed
the
tmpnet-network-uuids
branch
from
7b96e9f
to
ad1de96
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
fdd36d2
to
7e7a61a
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
7e7a61a
to
b23daef
Compare
marun
force-pushed
the
tmpnet-network-uuids
branch
2 times, most recently
from
a5cb88c
to
de22c95
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
b779e0a
to
99ac7d6
Compare
Previously, tmpnet networks were only identified by their path on disk. In anticipation of centralizing metrics collection for temporary networks, tmpnet will now generate a UUID for each temporary network to ensure a unique identifier across execution environments.
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
0971832
to
779044e
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
779044e
to
88c226b
Compare
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
88c226b
to
38f3d0d
Compare
Temporary networks used for testing previously lacked an easy way to enable metrics collection. This PR ensures that prometheus has what it needs to scrape the metrics endpoints of a temporary network and enables scraping of CI jobs using temporary networks. - Write prometheus configuration to ~/.tmpnet/prometheus/file_sd_configs for each node on startup and remove it on shutdown. This enables scraping of all nodes in a network no matter when they are started. Ref: https://prometheus.io/docs/guides/file-sd/ - Add script to scrape temporary networks with agent-mode prometheus. Works locally and in CI
marun
force-pushed
the
tmpnet-prometheus-config
branch
from
38f3d0d
to
f83d77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Temporary networks used for testing previously lacked an easy way to enable metrics collection. This PR ensures that prometheus has what it needs to scrape the metrics endpoints of a temporary network.
How this works
How this was tested
Locally tested.
TODO
tmpnet: Add a UUID to temporary networks to support metrics collection #2763