[network/p2p] Integrate new gossip into P-Chain #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
changed the base branch from
master
to
gossip-cleanup-suggestions
2 tasks
patrick-ogrady
commented
Feb 26, 2024
|
|
||
| n.txPushGossiper.Add(tx) |
There was a problem hiding this comment.
We should not enqueue push gossip from inbound p2p.
patrick-ogrady
commented
Feb 26, 2024
| @@ -219,7 +219,8 @@ func (vm *VM) Initialize( | |||
| vm.onShutdownCtx, vm.onShutdownCtxCancel = context.WithCancel(context.Background()) | |||
| // TODO: Wait for this goroutine to exit during Shutdown once the platformvm | |||
| // has better control of the context lock. | |||
| go vm.Network.Gossip(vm.onShutdownCtx) | |||
| go vm.Network.PushGossip(vm.onShutdownCtx) | |||
There was a problem hiding this comment.
Seems like these should be combined? Considered adding support for this in gossip.Every but got weird because frequency differed by gossiper.
StephenButtolph
requested review from
abi87,
danlaine,
dhrubabasu,
StephenButtolph and
joshua-kim
as code owners
StephenButtolph
merged commit bd99547
into
gossip-cleanup-suggestions
3 of 15 checks passed
mboben
pushed a commit
to mboben/avalanchego
that referenced
this pull request
Apr 7, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested