Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmpnet: Ensure nodes are properly detached from the parent process #2859

Merged
merged 6 commits into from
Mar 25, 2024

Commits on Mar 23, 2024

  1. tmpnet: Ensure nodes are properly detached from the parent process

    Previously tmpnet called `Cmd.Wait` on the node process based on a
    misreading of the advice of the `Cmd.Start` to ensure that system
    resources were freed. This ensured that any error in the parent
    process would result in the node processes being killed.
    
    Now, the child is properly detached by setting `Setsid` and avoiding
    calling Wait. This ensures that the node restarts required when
    setting up subnets (e.g. for subnet-evm or hypersdk) do not risk the
    nodes of an existing network being stopped if the test suite exits
    non-zero due to a test failure.
    marun committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ee30f31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec3755c View commit details
    Browse the repository at this point in the history
  3. Update tests/fixture/tmpnet/defaults.go

    Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
    Signed-off-by: marun <maru.newby@avalabs.org>
    marun and StephenButtolph committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    69f8c6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f7620cc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1f117c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Update tests/fixture/tmpnet/node_process.go

    Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
    Signed-off-by: Stephen Buttolph <stephen@avalabs.org>
    StephenButtolph and darioush committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    1eba9c9 View commit details
    Browse the repository at this point in the history