Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[antithesis] Ensure images with a prefix are pushed #3016

Merged
merged 2 commits into from
May 13, 2024
Merged

[antithesis] Ensure images with a prefix are pushed #3016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8277f6f
[antithesis] Ensure images with a prefix are pushed
marun May 13, 2024
08eed50
fixup: Rename action to include mention of 'push'
marun May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish_antithesis_images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
username: _json_key
password: ${{ secrets.ANTITHESIS_GAR_JSON_KEY }}

- name: Build images for avalanchego test setup
- name: Build and push images for avalanchego test setup
run: bash -x ./scripts/build_antithesis_images.sh
env:
IMAGE_PREFIX: ${{ env.REGISTRY }}/${{ env.REPOSITORY }}
Expand Down
4 changes: 4 additions & 0 deletions scripts/build_antithesis_images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ function build_images {

# Define default build command
local docker_cmd="docker buildx build --build-arg GO_VERSION=${GO_VERSION}"
if [[ -n "${IMAGE_PREFIX}" ]]; then
# Push images with an image prefix since the prefix defines a registry location
docker_cmd="${docker_cmd} --push"
fi

# Build node image first to allow the config and workload image builds to use it.
${docker_cmd} -t "${node_image_name}" -f "${node_dockerfile}" "${AVALANCHE_PATH}"
Expand Down
Loading