Remove deadcode #3086
Merged
Remove deadcode #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
danlaine,
joshua-kim and
StephenButtolph
as code owners
joshua-kim
reviewed
Jun 5, 2024
marun
reviewed
Jul 23, 2024
marun
approved these changes
Jul 23, 2024
There's a decent amount of false positives, this wouldn't really belong in CI IMO fwiw we already have |
StephenButtolph
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
s/o @darioush for pointing out this tool
How this works
Removes some deadcode. There may be more from that tool but these are the ones I feel comfortable with removing.
How this was tested
CI