Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[antithesis] Remove assertions incompatible with fault injection #3104

Merged
merged 3 commits into from
Jun 14, 2024
Merged

[antithesis] Remove assertions incompatible with fault injection #3104

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56ed6e8
[antithesis] Remove assertions incompatible with fault injection
marun Jun 11, 2024
ac92e91
fixup: Revert conditional change as per review comment
marun Jun 11, 2024
99cb508
merged
StephenButtolph Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
68 changes: 0 additions & 68 deletions tests/antithesis/avalanchego/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,6 @@ func (w *workload) issueXChainBaseTx(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain baseTx: %s", err)
assert.Unreachable("failed to issue X-chain baseTx", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("issued new X-chain baseTx %s in %s", baseTx.ID(), time.Since(baseStartTime))
Expand Down Expand Up @@ -320,10 +316,6 @@ func (w *workload) issueXChainCreateAssetTx(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain create asset transaction: %s", err)
assert.Unreachable("failed to issue X-chain create asset transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created new X-chain asset %s in %s", createAssetTx.ID(), time.Since(createAssetStartTime))
Expand Down Expand Up @@ -378,10 +370,6 @@ func (w *workload) issueXChainOperationTx(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain create asset transaction: %s", err)
assert.Unreachable("failed to issue X-chain create asset transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created new X-chain asset %s in %s", createAssetTx.ID(), time.Since(createAssetStartTime))
Expand All @@ -393,10 +381,6 @@ func (w *workload) issueXChainOperationTx(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain operation transaction: %s", err)
assert.Unreachable("failed to issue X-chain operation transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("issued X-chain operation tx %s in %s", operationTx.ID(), time.Since(operationStartTime))
Expand Down Expand Up @@ -456,10 +440,6 @@ func (w *workload) issueXToPTransfer(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain export transaction: %s", err)
assert.Unreachable("failed to issue X-chain export transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created X-chain export transaction %s in %s", exportTx.ID(), time.Since(exportStartTime))
Expand All @@ -474,10 +454,6 @@ func (w *workload) issueXToPTransfer(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue P-chain import transaction: %s", err)
assert.Unreachable("failed to issue P-chain import transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created P-chain import transaction %s in %s", importTx.ID(), time.Since(importStartTime))
Expand Down Expand Up @@ -538,10 +514,6 @@ func (w *workload) issuePToXTransfer(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue P-chain export transaction: %s", err)
assert.Unreachable("failed to issue P-chain export transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created P-chain export transaction %s in %s", exportTx.ID(), time.Since(exportStartTime))
Expand All @@ -553,10 +525,6 @@ func (w *workload) issuePToXTransfer(ctx context.Context) {
)
if err != nil {
log.Printf("failed to issue X-chain import transaction: %s", err)
assert.Unreachable("failed to issue X-chain import transaction", map[string]any{
"worker": w.id,
"err": err,
})
return
}
log.Printf("created X-chain import transaction %s in %s", importTx.ID(), time.Since(importStartTime))
Expand Down Expand Up @@ -584,22 +552,10 @@ func (w *workload) confirmXChainTx(ctx context.Context, tx *xtxs.Tx) {
status, err := client.ConfirmTx(ctx, txID, 100*time.Millisecond)
if err != nil {
log.Printf("failed to confirm X-chain transaction %s on %s: %s", txID, uri, err)
assert.Unreachable("failed to determine the status of an X-chain transaction", map[string]any{
"worker": w.id,
"txID": txID,
"uri": uri,
"err": err,
})
return
}
if status != choices.Accepted {
log.Printf("failed to confirm X-chain transaction %s on %s: status == %s", txID, uri, status)
assert.Unreachable("failed to confirm an X-chain transaction", map[string]any{
"worker": w.id,
"txID": txID,
"uri": uri,
"status": status,
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that this assertion could remain. (I'd be interested if it couldn't stay)

Copy link
Collaborator

@aaronbuchwald aaronbuchwald Jun 12, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, if this hits an error here: https://github.com/ava-labs/avalanchego/blob/master/wallet/chain/x/wallet.go#L303 when issuing the transaction while the node is down due to an injected failure then the test will fail incorrectly

Ignore my comment - this is specifically checking the status that was returned assuming the API call has already returned without an error.

return
}
log.Printf("confirmed X-chain transaction %s on %s", txID, uri)
Expand All @@ -614,22 +570,10 @@ func (w *workload) confirmPChainTx(ctx context.Context, tx *ptxs.Tx) {
s, err := client.AwaitTxDecided(ctx, txID, 100*time.Millisecond)
if err != nil {
log.Printf("failed to determine the status of a P-chain transaction %s on %s: %s", txID, uri, err)
assert.Unreachable("failed to determine the status of a P-chain transaction", map[string]any{
"worker": w.id,
"txID": txID,
"uri": uri,
"err": err,
})
return
}
if s.Status != status.Committed {
log.Printf("failed to confirm P-chain transaction %s on %s: status == %s", txID, uri, s.Status)
assert.Unreachable("failed to confirm a P-chain transaction", map[string]any{
"worker": w.id,
"txID": txID,
"uri": uri,
"status": s.Status,
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my understanding that this assertion could remain. (I'd be interested if it couldn't stay)

return
}
log.Printf("confirmed P-chain transaction %s on %s", txID, uri)
Expand All @@ -655,12 +599,6 @@ func (w *workload) verifyXChainTxConsumedUTXOs(ctx context.Context, tx *xtxs.Tx)
)
if err != nil {
log.Printf("failed to fetch X-chain UTXOs on %s: %s", uri, err)
assert.Unreachable("failed to fetch X-chain UTXOs", map[string]any{
"worker": w.id,
"txID": txID,
"uri": uri,
"err": err,
})
return
}

Expand Down Expand Up @@ -701,12 +639,6 @@ func (w *workload) verifyPChainTxConsumedUTXOs(ctx context.Context, tx *ptxs.Tx)
)
if err != nil {
log.Printf("failed to fetch P-chain UTXOs on %s: %s", uri, err)
assert.Unreachable("failed to fetch P-chain UTXOs", map[string]any{
"worker": w.id,
"uri": uri,
"txID": txID,
"err": err,
})
return
}

Expand Down
6 changes: 0 additions & 6 deletions tests/antithesis/xsvm/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,6 @@ func (w *workload) confirmTransferTx(ctx context.Context, tx *status.TxIssuance)
client := api.NewClient(uri, w.chainID.String())
if err := api.WaitForAcceptance(ctx, client, w.key.Address(), tx.Nonce); err != nil {
log.Printf("worker %d failed to confirm transaction %s on %s: %s", w.id, tx.TxID, uri, err)
assert.Unreachable("failed to confirm transaction", map[string]any{
"worker": w.id,
"txID": tx.TxID,
"uri": uri,
"err": err,
})
return
}
}
Expand Down