[vms/platformvm] Add tracking of a Subnet manager #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrubabasu
requested review from
abi87,
danlaine and
StephenButtolph
as code owners
dhrubabasu
commented
Jun 18, 2024
Signed-off-by: Dhruba Basu <7675102+dhrubabasu@users.noreply.github.com>
marun
reviewed
Jun 19, 2024
marun
approved these changes
Jul 22, 2024
| @@ -21,6 +21,7 @@ var DefaultExecutionConfig = ExecutionConfig{ | |||
| ChainDBCacheSize: 2048, | |||
| BlockIDCacheSize: 8192, | |||
| FxOwnerCacheSize: 4 * units.MiB, | |||
| SubnetManagerCacheSize: 2048, | |||
There was a problem hiding this comment.
This is pretty confusing. All of the bytes caches use units.MiB to be clear that it is representing bytes. All of the other values are denominating the number of entries.
This entry is interpreted as bytes - but is set as if it is in the number of entries.
I think we should either be specifying 2 * units.KiB or we should be setting this to a different value (if the assumption was that this is denominated in entries rather than bytes)
vms/platformvm/state/state_test.go
Outdated
| }, | ||
| { | ||
| name: "cache", | ||
| setup: func(s State, subnetID ids.ID, chainID ids.ID, addr []byte) { |
There was a problem hiding this comment.
Should this pass in the *testing.T or the *require.Assertions? Right now this function is executed by the inner test but uses the outer testing struct.
StephenButtolph
approved these changes
Aug 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-77 introduces a notion of a "Subnet manager" defined as a
sourceChainIDandsourceAddresspair. This PR adds tracking of this pair to the P-Chain state.How this works
Adds support for storing and retrieving a
chainIDandaddrfor each SubnetHow this was tested
CI + added UTs