Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent lookup from issue #3132

Merged
merged 23 commits into from
Jun 27, 2024
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
fb43108
Replace wasIssued
StephenButtolph Jun 19, 2024
202cc2e
backport
StephenButtolph Jun 19, 2024
317bb5a
Remove parent lookup from issue
StephenButtolph Jun 20, 2024
ad05b22
Add regression test
StephenButtolph Jun 20, 2024
8793de4
Fix regression test to pass on master
StephenButtolph Jun 20, 2024
d023b41
nit
StephenButtolph Jun 20, 2024
3595874
Introduce canDependOn
StephenButtolph Jun 20, 2024
14b76b7
nit
StephenButtolph Jun 20, 2024
3f6bba4
lint
StephenButtolph Jun 20, 2024
29ce725
add todo
StephenButtolph Jun 20, 2024
ca3fd85
merged
StephenButtolph Jun 20, 2024
094e5d9
Merge branch 'improve-was-issued' into remove-block-lookup-2
StephenButtolph Jun 20, 2024
f3987cc
Merge branch 'master' into simplify-dependency-registration
StephenButtolph Jun 20, 2024
61bb415
fix merge
StephenButtolph Jun 20, 2024
ca5560e
Merge branch 'simplify-dependency-registration' into improve-was-issued
StephenButtolph Jun 20, 2024
fb7b550
Merge branch 'improve-was-issued' into remove-block-lookup-2
StephenButtolph Jun 20, 2024
0fdca3e
nit comment
StephenButtolph Jun 24, 2024
61f6c42
Merge branch 'improve-was-issued' into remove-block-lookup-2
StephenButtolph Jun 24, 2024
e7caabe
nit
StephenButtolph Jun 25, 2024
46cce68
Merge branch 'master' into simplify-dependency-registration
StephenButtolph Jun 25, 2024
13d756a
Merge branch 'simplify-dependency-registration' into improve-was-issued
StephenButtolph Jun 25, 2024
ae07a68
Merge branch 'improve-was-issued' into remove-block-lookup-2
StephenButtolph Jun 25, 2024
b69aca6
Merge branch 'master' into remove-block-lookup-2
StephenButtolph Jun 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions snow/engine/snowman/transitive.go
Original file line number Diff line number Diff line change
Expand Up @@ -827,12 +827,10 @@ func (t *Transitive) issue(
issuedMetric: issuedMetric,
}

// block on the parent if needed
var (
parentID = blk.Parent()
deps []ids.ID
)
if parent, err := t.getBlock(ctx, parentID); err != nil || !(t.isDecided(parent) || t.Consensus.Processing(parentID)) {
// We know that shouldIssueBlock(blk) is true. This means that parent is
// either the last accepted block or is not decided.
var deps []ids.ID
if parentID := blk.Parent(); !t.canIssueChildOn(parentID) {
t.Ctx.Log.Verbo("block waiting for parent to be issued",
zap.Stringer("blkID", blkID),
zap.Stringer("parentID", parentID),
Expand Down
Loading