-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Simplify ci monitoring with custom actions #3161
Conversation
ef42cbe
to
b86900a
Compare
1c5e485
to
88fe236
Compare
6ab66ce
to
ea1b24c
Compare
ca36d5f
to
2144e36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Note that if you get to the point where you'd be using the same action across multiple github repositories, you could create a "common" repository that would host these shared actions.
That's particulary useful when you have a username/password that is stored as part of the repository secrets, and you want to make sure there is only a single "instance" of it.
It won't actually be necessary to put these actions in a different repo to enable reuse. That's already possible from this repo. I intend to update subnet-evm and hypersdk to use the new actions defined in this PR. But custom actions don't enable sharing of secrets, as per the example of each invocation of the monitoring action in this PR needing to provide the monitoring secrets. Custom actions are a bit strange in their access to the environment - context values are accessible via input defaults but not directly in steps, and secrets are not accessible at all and need to be provided via inputs. |
Previously, enabling monitoring of temporary networks for a CI job required duplicating complicated action steps. Encapsulating those steps in a custom action is intended to simplify maintenance and enable direct reuse by other repos (e.g. subnet-evm, hypersdk).
TODO