Replace usage of utils.Err with errors.Join #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
requested review from
danlaine,
darioush,
dboehm-avalabs,
abi87,
StephenButtolph and
dhrubabasu
as code owners
dhrubabasu
reviewed
Jul 2, 2024
| func Err(errors ...error) error { | ||
| for _, err := range errors { | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
A subtle change between errors.Join and utils.Err is that utils.Err returns the first error whereas errors.Join returns a combined error (https://go.dev/play/p/n4_zaEd4ODl):
import (
"errors"
"fmt"
)
func main() {
err1 := errors.New("err1")
err2 := errors.New("err2")
err := errors.Join(err1, err2)
fmt.Println(err)
if errors.Is(err, err1) {
fmt.Println("err is err1")
}
if errors.Is(err, err2) {
fmt.Println("err is err2")
}
}err1
err2
err is err1
err is err2
There was a problem hiding this comment.
I don't think this matters for our use-cases but thought I'd point it out
dhrubabasu
reviewed
Jul 2, 2024
StephenButtolph
approved these changes
Jul 2, 2024
dhrubabasu
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Remove helper we maintain and use the stdlib instead
How this works
Removes
utils.ErrHow this was tested
CI