Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/merkledb: eth compatible root calculation #3168

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

darioush
Copy link
Contributor

@darioush darioush commented Jul 3, 2024

Why this should be merged

Adds an eth compatible hashing mechanism for the merkledb

How this works

  • Passes the parent through to hashing ()
  • Allows for nodes with rlp representation < 32 bytes to be encoded as their preimage (per rlp spec)
  • Allows hasher to determine empty root ID

How this was tested

UTs (simple, random)

@darioush darioush added the DO NOT MERGE This PR must not be merged in its current state label Jul 3, 2024
@darioush darioush changed the title add "embed" field to encoded child x/merkledb: eth compatible root calculation Jul 3, 2024
Copy link

github-actions bot commented Aug 4, 2024

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This PR must not be merged in its current state lifecycle/stale
Projects
Status: Backlog 🗄️
Development

Successfully merging this pull request may close these issues.

None yet

1 participant