[antithesis] Refactor compose config generation to simplify reuse #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
force-pushed
the
antithesis-simplify-genconfig
branch
from
444ab35
to
bf44343
Compare
joshua-kim
approved these changes
Jul 15, 2024
tests/antithesis/compose.go
Outdated
Comment on lines
32
to
58
| if len(targetPath) == 0 { | ||
| return errors.New("TARGET_PATH environment variable not set") | ||
| } | ||
|
|
||
| imageTag := os.Getenv("IMAGE_TAG") | ||
| if len(imageTag) == 0 { | ||
| return errors.New("IMAGE_TAG environment variable not set") | ||
| } | ||
|
|
||
| // Subnet testing requires creating an initial db state for the bootstrap node | ||
| if len(network.Subnets) > 0 { | ||
| avalancheGoPath := os.Getenv("AVALANCHEGO_PATH") | ||
| if len(avalancheGoPath) == 0 { | ||
| return errors.New("AVALANCHEGO_PATH environment variable not set") | ||
| } | ||
|
|
||
| pluginDir := os.Getenv("AVALANCHEGO_PLUGIN_DIR") | ||
| if len(pluginDir) == 0 { | ||
| return errors.New("AVALANCHEGO_PLUGIN_DIR environment variable not set") | ||
| } |
There was a problem hiding this comment.
Rather than using errors.New directly in the return - can we define them as variables? There is a longstanding goal I've had to add goerr113 as a linter... But there have been a few blockers (but this would be prevented by that linter)
There was a problem hiding this comment.
Done.
I forget, why is this important?
There was a problem hiding this comment.
In this case it isn't super important (more of a consistency style thing). But in other locations it's important to be able to test the different error conditions more naturally (with errors.Is)
marun
force-pushed
the
antithesis-simplify-genconfig
branch
from
1ecdfec
to
7fee75d
Compare
StephenButtolph
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Refactor generation of compose configuration for antithesis test setups to simplify reuse by subnet-evm.
How this works
Creates a new function (
GenerateComposeConfig) that encapsulates generation of docker-compose.yml and associated initial db state (if testing a VM) for any antithesis test setup.How this was tested
CI