P-chain: updating wallet to use dynamic fee calculator #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
changed the title
abi87
changed the title
abi87
force-pushed
the
p-chain_update_wallet
branch
from
6b8d844
to
07456ae
Compare
abi87
force-pushed
the
p-chain_update_wallet
branch
from
52ae6a1
to
048a14c
Compare
abi87
requested review from
danlaine,
dhrubabasu and
StephenButtolph
as code owners
This was referenced Jul 15, 2024
| @@ -252,7 +255,11 @@ func newEnvironment(t *testing.T, ctrl *gomock.Controller, f fork) *environment | |||
| } | |||
|
|
|||
| func addSubnet(env *environment) { | |||
| builder, signer := env.factory.NewWallet(preFundedKeys[0]) | |||
| builder, signer, feeCalc, err := env.factory.NewWallet(preFundedKeys[0]) | |||
There was a problem hiding this comment.
maybe add the t *testing.T to the addSubnet instead of panic'ing ?
| } | ||
|
|
||
| // GetNextFeeRates returns the next fee rates that a transaction must pay to be accepted now | ||
| func (s *Service) GetDynamicFeeConfig(_ *http.Request, _ *struct{}, reply *DynamicFeesConfigReply) error { |
There was a problem hiding this comment.
The method, as implemented, makes me feel a bit uncomfortable. The reply is being used in some cases, but not in others, and the caller is expected to deduce that by examining the error code. In addition, the caller is expected to provide a valid reply pointer, or the method might (sometimes) panic.
I know that this aligns with the existing calling convension in this file, and was wondering if there is a good reason for that. In particular, I would that written it as
func (s *Service) GetDynamicFeeConfig(_ *http.Request, _ *struct{}) (reply *DynamicFeesConfigReply, err error) since that would have the convention that the err and the reply are mutually exclusive.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Splitting introduction of dynamic fees into 4 PRs:
How this works
How this was tested
Extra UTs. All new code is not wired in yet. Will be done in a sequent PR