-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[antithesis] Add schedule for workflows #3192
Conversation
@@ -1,7 +1,8 @@ | |||
name: Trigger Antithesis Avalanchego Setup | |||
|
|||
on: | |||
# TODO(marun) Add a schedule to execute regularly | |||
schedule: | |||
- cron: '0 22 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about crontab.guru
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments for the human-readable version of this.
@@ -35,4 +36,4 @@ jobs: | |||
images: antithesis-avalanchego-workload:${{ github.event.inputs.image_tag || 'latest' }};antithesis-avalanchego-node:${{ github.event.inputs.image_tag || 'latest' }} | |||
email_recipients: ${{ github.event.inputs.recipients || secrets.ANTITHESIS_RECIPIENTS }} | |||
additional_parameters: |- | |||
custom.duration=${{ github.event.inputs.duration || '0.5' }} | |||
custom.duration=${{ github.event.inputs.duration || '11.25' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own knowledge, what are the units here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated input labels and added comments indicating units of duration
The proposed schedule mirrors the current schedule implemented on the antithesis side.
4c1f753
to
3caba51
Compare
The proposed schedule mirrors the current schedule implemented on the antithesis side.