Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antithesis] Add schedule for workflows #3192

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

marun
Copy link
Contributor

@marun marun commented Jul 15, 2024

The proposed schedule mirrors the current schedule implemented on the antithesis side.

@marun marun self-assigned this Jul 15, 2024
@marun marun added the ci This focuses on changes to the CI process label Jul 15, 2024
@@ -1,7 +1,8 @@
name: Trigger Antithesis Avalanchego Setup

on:
# TODO(marun) Add a schedule to execute regularly
schedule:
- cron: '0 22 * * *'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about crontab.guru

Copy link
Contributor Author

@marun marun Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for the human-readable version of this.

@@ -35,4 +36,4 @@ jobs:
images: antithesis-avalanchego-workload:${{ github.event.inputs.image_tag || 'latest' }};antithesis-avalanchego-node:${{ github.event.inputs.image_tag || 'latest' }}
email_recipients: ${{ github.event.inputs.recipients || secrets.ANTITHESIS_RECIPIENTS }}
additional_parameters: |-
custom.duration=${{ github.event.inputs.duration || '0.5' }}
custom.duration=${{ github.event.inputs.duration || '11.25' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own knowledge, what are the units here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hours

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated input labels and added comments indicating units of duration

The proposed schedule mirrors the current schedule implemented on the
antithesis side.
@StephenButtolph StephenButtolph added this pull request to the merge queue Jul 16, 2024
@StephenButtolph StephenButtolph added this to the v1.11.10 milestone Jul 16, 2024
Merged via the queue into master with commit 169659b Jul 16, 2024
20 checks passed
@StephenButtolph StephenButtolph deleted the antithesis-add-schedule branch July 16, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This focuses on changes to the CI process
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants