Fix comparison comment in snowflake algorithms #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
changed the title
StephenButtolph
approved these changes
Aug 1, 2024
In the snowflake algorithms, there is the following comment: // terminationConditions[i].alphaConfidence < terminationConditions[i+1].alphaConfidence // terminationConditions[i].beta <= terminationConditions[i+1].beta However, the two lines contradict, as if alpha confidence grows with i, then beta should decrease and not increase. The reason is that the higher our confidence, the less consecutive polls we need to finalize. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
yacovm
force-pushed
the
fixTypoSnowflake
branch
from
386dd30 to
32f03f9
Compare
StephenButtolph
added
documentation
aaronbuchwald
approved these changes
Aug 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🤔 I wonder if we broke the merge queue for PRs coming from forks |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
it's not my first PR from a fork, maybe there could be another explanation? |
tsachiherman
pushed a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In the snowflake algorithms, there is the following comment:
However, the two lines contradict, as if alpha confidence grows with i, then beta should decrease and not increase. The reason is that the higher our confidence, the less consecutive polls we need to finalize.
How this works
Just a comment fix
How this was tested
No need to test, it's a comment fix.