Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate e2e tests by etna activation #3268

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Aug 4, 2024

Why this should be merged

This converts the single e2e test network (which currently runs with the Etna upgrade activated) into two e2e test networks:

  1. e2e tests with Etna activated
  2. e2e tests without Etna activated
    All the tests run on each network - if a test is upgrade dependent, then it should check the network setup internally.

How this works

  • Adds --activate-etna to the tmpnet flags.
  • Adds a new test with --activate-etna provided.

How this was tested

@StephenButtolph StephenButtolph marked this pull request as ready for review August 4, 2024 22:10
@StephenButtolph StephenButtolph self-assigned this Aug 4, 2024
@StephenButtolph StephenButtolph added testing This primarily focuses on testing acp77 acp103 labels Aug 4, 2024
@StephenButtolph StephenButtolph added this to the v1.11.11 milestone Aug 4, 2024
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test intended to exist long-term, or is it temporarily validating configuration of etna enablement in advance of future work to:

  • add a helper to encapsulate determination of etna activation
  • use that helper to skip tests that are not compatible with etna

.github/workflows/ci.yml Show resolved Hide resolved
tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
tests/e2e/etna/suites.go Outdated Show resolved Hide resolved
tests/e2e/etna/suites.go Outdated Show resolved Hide resolved
@StephenButtolph
Copy link
Contributor Author

Is this test intended to exist long-term, or is it temporarily validating configuration of etna enablement in advance of future work

It was primarily added here to serve as an example of how to detect+skip if Etna is active (for the future e2e tests we are going to build out).

I also felt like it may be useful as we add additional Etna functionality to expand on this test... but if we don't think this test is useful in its current form, we can remove it.

@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 5, 2024
@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit ec8a639 Aug 5, 2024
21 checks passed
@StephenButtolph StephenButtolph deleted the add-etna-e2e-test branch August 5, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acp77 acp103 testing This primarily focuses on testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants