-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate e2e tests by etna activation #3268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this test intended to exist long-term, or is it temporarily validating configuration of etna enablement in advance of future work to:
- add a helper to encapsulate determination of etna activation
- use that helper to skip tests that are not compatible with etna
It was primarily added here to serve as an example of how to detect+skip if Etna is active (for the future e2e tests we are going to build out). I also felt like it may be useful as we add additional Etna functionality to expand on this test... but if we don't think this test is useful in its current form, we can remove it. |
Why this should be merged
This converts the single e2e test network (which currently runs with the Etna upgrade activated) into two e2e test networks:
All the tests run on each network - if a test is upgrade dependent, then it should check the network setup internally.
How this works
--activate-etna
to the tmpnet flags.--activate-etna
provided.How this was tested