ACP-77: Implement RegisterSubnetValidatorTx
#3420
Conversation
StephenButtolph
changed the title
RegisterSubnetValidatorTxRegisterSubnetValidatorTx
…cp-77-deactivation
…date-convert-subnet-tx
…nt-acp-77-register-subnet-validator-tx
…cp-77-deactivation
…date-convert-subnet-tx
…cp-77-deactivation
…date-convert-subnet-tx
…nt-acp-77-register-subnet-validator-tx
…cp-77-deactivation
…date-convert-subnet-tx
…nt-acp-77-register-subnet-validator-tx
…7-register-subnet-validator-tx
There was a problem hiding this comment.
Generally makes sense to me. Left one comment about sentence I couldn't parse.
For the TODOs that are waiting on ACP-103 numbers, it might be helpful for both reviewers of this PR and whoever fixes the TODOs to label the TODOs specifically as TODO ACP-103 or something similar.
vms/platformvm/validators/manager.go
Outdated
| // to avoid recommending it as the minimum height. If the evicting, or not | ||
| // evicting, the block would violate either the maxiumum or minimum window | ||
| // size, the block will not be evicted. |
There was a problem hiding this comment.
This sentence doesn't seem to make sense
There was a problem hiding this comment.
Agree with @geoff-vball suggestion for a searchable prefix on each of the TODOs added in this PR that we will want to confirm have been completed, but all makes sense to me otherwise.
I added |
SGTM |
StephenButtolph
deleted the
implement-acp-77-register-subnet-validator-tx
branch
Why this should be merged
This PR introduces the
RegisterSubnetValidatorTxdefined by ACP-77.This PR includes:
RegisterSubnetValidatorTxserialization definitionRegisterSubnetValidatorTxbuilding and wallet supportRegisterSubnetValidatorTxRegisterSubnetValidatorTxRegisterSubnetValidatorTxThis PR does not include:
RegisterSubnetValidatorTxHow this works
This PR adds the new
RegisterSubnetValidatorTxtype and implements all the required visitors.How this was tested