-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACP-77: Implement DisableSubnetValidatorTx #3440
Merged
StephenButtolph
merged 846 commits into
master
from
implement-acp-77-disable-subnet-validator-tx
Nov 13, 2024
Merged
ACP-77: Implement DisableSubnetValidatorTx #3440
StephenButtolph
merged 846 commits into
master
from
implement-acp-77-disable-subnet-validator-tx
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cp-77-deactivation
…cp-77-deactivation
…cp-77-deactivation
…crease-balance-tx
…p-77-disable-subnet-validator-tx
…p-77-disable-subnet-validator-tx
marun
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e LGTM
…crease-balance-tx
…p-77-disable-subnet-validator-tx
…crease-balance-tx
…p-77-disable-subnet-validator-tx
Base automatically changed from
implement-acp-77-increase-balance-tx
to
master
November 13, 2024 17:34
StephenButtolph
deleted the
implement-acp-77-disable-subnet-validator-tx
branch
November 13, 2024 18:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR introduces the
DisableSubnetValidatorTx
defined by ACP-77.This PR includes:
DisableSubnetValidatorTx
serialization definitionDisableSubnetValidatorTx
building and wallet supportDisableSubnetValidatorTx
DisableSubnetValidatorTx
DisableSubnetValidatorTx
This PR does not include the finalized ACP-103 complexity values for
DisableSubnetValidatorTx
How this works
This PR adds the new
DisableSubnetValidatorTx
type and implements all the required visitors.How this was tested