Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-77: Implement DisableSubnetValidatorTx #3440

Merged
merged 846 commits into from
Nov 13, 2024

Conversation

StephenButtolph
Copy link
Contributor

@StephenButtolph StephenButtolph commented Oct 2, 2024

Why this should be merged

This PR introduces the DisableSubnetValidatorTx defined by ACP-77.

This PR includes:

  • DisableSubnetValidatorTx serialization definition
  • DisableSubnetValidatorTx building and wallet support
  • (Basic) complexity calculations for DisableSubnetValidatorTx
  • Execution logic and rules for DisableSubnetValidatorTx
  • Example usage of DisableSubnetValidatorTx

This PR does not include the finalized ACP-103 complexity values for DisableSubnetValidatorTx

How this works

This PR adds the new DisableSubnetValidatorTx type and implements all the required visitors.

How this was tested

  • Added unit tests for all new code
  • Added e2e test for new transaction type

@StephenButtolph StephenButtolph self-assigned this Oct 2, 2024
@StephenButtolph StephenButtolph added this to the v1.12.0-prerelease milestone Oct 4, 2024
Copy link
Contributor

@marun marun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e LGTM

Base automatically changed from implement-acp-77-increase-balance-tx to master November 13, 2024 17:34
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 92f0f59 Nov 13, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-77-disable-subnet-validator-tx branch November 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants