Allow issuing transactions when using partial-sync #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
reviewed
Nov 25, 2024
yacovm
reviewed
Nov 25, 2024
yacovm
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently if
--partial-sync-primary-networkis set, theplatform.issueTxAPI is disabled. This PR allows issuing transactions that can be verified by the node.How this works
When
--partial-sync-primary-networkis enabled, banImportTxs. Otherwise, allow transactions to be issued as normal.How this was tested
Locally issued P-chain transactions to Fuji through a partial synced node.
Need to be documented in RELEASES.md?
There is currently no reference to
--partial-sync-primary-networkin the docs forissueTx.