Support Custom Genesis Config for Non-Standard NetworkIDs #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
force-pushed
the
genesis-config-flag
branch
from
5711049
to
1ea97f5
Compare
Codecov Report
@@ Coverage Diff @@
## dev #719 +/- ##
===================================================
+ Coverage 56.69442% 56.86361% +0.16919%
===================================================
Files 320 320
Lines 20420 20514 +94
===================================================
+ Hits 11577 11665 +88
- Misses 7586 7591 +5
- Partials 1257 1258 +1 |
patrick-ogrady
force-pushed
the
genesis-config-flag
branch
from
6ed07bd
to
d724f87
Compare
patrick-ogrady
changed the title
patrick-ogrady
commented
Jan 20, 2021
genesis/genesis_test.go
Outdated
| "fuji": { | ||
| networkID: constants.FujiID, | ||
| customConfig: localGenesisConfigJSON, // won't load | ||
| expected: "2e6b699298a664793bff42dae9c1af8d9c54645d8b376fd331e0b67475578e0a", |
There was a problem hiding this comment.
there is probably a better way to do this....
There was a problem hiding this comment.
I thought about using an anonymous function to load these on-the-fly but didn't like the look (basically just replicated the logic of Genesis to create the Config we wanted)...still thinking.
patrick-ogrady
commented
Jan 20, 2021
danlaine
reviewed
Jan 20, 2021
danlaine
reviewed
Jan 20, 2021
patrick-ogrady
changed the title
patrick-ogrady
force-pushed
the
genesis-config-flag
branch
4 times, most recently
from
c928a60
to
bea5d88
Compare
patrick-ogrady
commented
Jan 20, 2021
patrick-ogrady
commented
Jan 20, 2021
patrick-ogrady
force-pushed
the
genesis-config-flag
branch
from
a08c83a
to
1a9e74b
Compare
patrick-ogrady
changed the title
patrick-ogrady
force-pushed
the
genesis-config-flag
branch
from
1a9e74b
to
1a9cb7b
Compare
danlaine
reviewed
Jan 21, 2021
danlaine
reviewed
Jan 21, 2021
danlaine
reviewed
Jan 21, 2021
danlaine
approved these changes
Jan 22, 2021
StephenButtolph
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--genesisCLI argument that enables the user to specify the genesis config of the custom network their node is going to be running.Changes
--genesisimplementationinitialStakedFundstypo ingenesis/config.goFollow-Ups
assert.Error; assert.Containstoassert.ErrorContainsonce stretchr/testify@v1.8.0 released