chore(lint): cleanup config and enable default linters for our code #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/linter-new-only
branch
2 times, most recently
from
f9798f5 to
3eddab0
Compare
qdm12
changed the title
- enable errcheck - enable staticcheck - only scans plugin directory and _ext.go files - fix lint errors
qdm12
force-pushed
the
qdm12/linter-new-only
branch
from
3eddab0 to
bff54b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
errorlintfor our code only:./plugindirectory_ext.gofilesMore linters can be added subsequently, but this PR fixes already quite a few errors coming from enabling errchec, staticcheck and errorlint in the plugin directory.
How this works
How this was tested
Need to be documented?
No
Need to update RELEASES.md?
No