Upgrade nix #226
Merged
Upgrade nix #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two major changes: - features must be included; we only need two (this will speed up compiles!) - FD safety; we now need an OwnedFd, so attempting to use the fd after the object is dropped is no longer valid. Additionally, we don't need to implement Drop, as OwnedFd already has a drop which calls close References: * nix-rust/nix#2091 - nix PR for features drop * https://doc.rust-lang.org/stable/src/std/os/fd/owned.rs.html#170-182 - OwnedFd docs * nix-rust/nix#1906 - nix PR for FD I/O safety
rkuris
force-pushed
the
rkuris/nix-old-nix
branch
from
927dc4d
to
f44fed1
Compare
richardpringle
approved these changes
Aug 28, 2023
| pub struct File { | ||
| fd: Fd, | ||
| fd: OwnedFd, |
firewood/src/file.rs
Outdated
| } | ||
|
|
||
| type Target = OwnedFd; |
There was a problem hiding this comment.
nit: can you move this to the top of the impl block, please?
Per review comments
richardpringle
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes:
References: