Remove rejected from controller interface (#1140)

* Remove rejected from controller interface

* Update mocks and remove unused mock_auth from mocks.mockgen.txt

---------

Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>

README.md

@@ -576,7 +576,6 @@ type Controller interface {
 	// Anything that the VM wishes to store outside of state or blocks must be
 	// recorded here
 	Accepted(ctx context.Context, blk *chain.StatelessBlock) error
-	Rejected(ctx context.Context, blk *chain.StatelessBlock) error
 
 	// Shutdown should be used by the [Controller] to terminate any async
 	// processes it may be running in the background. It is invoked when

examples/morpheusvm/controller/controller.go

@@ -177,10 +177,6 @@ func (c *Controller) Accepted(ctx context.Context, blk *chain.StatelessBlock) er
 	return batch.Write()
 }
 
-func (*Controller) Rejected(context.Context, *chain.StatelessBlock) error {
-	return nil
-}
-
 func (*Controller) Shutdown(context.Context) error {
 	// Do not close any databases provided during initialization. The VM will
 	// close any databases your provided.

examples/tokenvm/controller/controller.go

@@ -216,10 +216,6 @@ func (c *Controller) Accepted(ctx context.Context, blk *chain.StatelessBlock) er
 	return batch.Write()
 }
 
-func (*Controller) Rejected(context.Context, *chain.StatelessBlock) error {
-	return nil
-}
-
 func (*Controller) Shutdown(context.Context) error {
 	// Do not close any databases provided during initialization. The VM will
 	// close any databases your provided.

scripts/mocks.mockgen.txt

@@ -1,3 +1,2 @@
-github.com/ava-labs/hypersdk/chain=Auth=chain/mock_auth.go
 github.com/ava-labs/hypersdk/chain=Rules=chain/mock_rules.go
 github.com/ava-labs/hypersdk/vm=Controller=vm/mock_controller.go

vm/dependencies.go

@@ -129,7 +129,6 @@ type Controller interface {
 	// Anything that the VM wishes to store outside of state or blocks must be
 	// recorded here
 	Accepted(ctx context.Context, blk *chain.StatelessBlock) error
-	Rejected(ctx context.Context, blk *chain.StatelessBlock) error
 
 	// Shutdown should be used by the [Controller] to terminate any async
 	// processes it may be running in the background. It is invoked when

vm/resolutions.go

@@ -144,10 +144,6 @@ func (vm *VM) Rejected(ctx context.Context, b *chain.StatelessBlock) {
 	vm.verifiedL.Unlock()
 	vm.mempool.Add(ctx, b.Txs)
 
-	if err := vm.c.Rejected(ctx, b); err != nil {
-		vm.Fatal("rejected processing failed", zap.Error(err))
-	}
-
 	// Ensure children of block are cleared, they may never be
 	// verified
 	vm.snowCtx.Log.Info("rejected block", zap.Stringer("id", b.ID()))