[chain] Refactor Base into Transaction
#1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iFrostizz
commented
Jun 13, 2024
Comment on lines
-48
to
-50
| func (*Base) Size() int { | ||
| return BaseSize | ||
| } |
There was a problem hiding this comment.
I noticed that Size(), even if defined, didn't seemed to be used. So I just deleted the whole file because all of the other methods have been inlined into Transaction.
iFrostizz
commented
Jun 13, 2024
iFrostizz
commented
Jun 13, 2024
cli/spam.go
Outdated
Comment on lines
474
to
476
| func (t *timeModifier) Base(b *chain.Transaction) { | ||
| b.Timestamp = t.Timestamp | ||
| } |
There was a problem hiding this comment.
Do we really want the modifier to have access to the full Transaction ?
iFrostizz
force-pushed
the
refactor_base_into_transaction
branch
from
b949d93
to
423c401
Compare
iFrostizz
force-pushed
the
refactor_base_into_transaction
branch
from
92b1b77
to
68b525a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
iFrostizz
force-pushed
the
refactor_base_into_transaction
branch
from
5166693
to
064b705
Compare
|
I don't think we want to use the modifier as it's used in this PR long term. Closing in favor of a different tx/action refactor later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685
Making the
Basepart of theTransactionso that their relationship is clearer.