Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify StatelessBlock and StatefulBlock #1067

Closed
wants to merge 2 commits into from
Closed

Unify StatelessBlock and StatefulBlock #1067

wants to merge 2 commits into from

Conversation

iFrostizz
Copy link
Contributor

Closes #342

Create a single Block interface, with StatelessBlock and StatefulBlock which implements it.
New names for StatelessBlock and StatefulBlock are TBD.

@iFrostizz iFrostizz self-assigned this Jun 20, 2024
@iFrostizz iFrostizz marked this pull request as ready for review June 21, 2024 13:59
@iFrostizz
Copy link
Contributor Author

We should probably rename those to Block for stateless and WrappedBlock or VMBlock for stateful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

Assignees

@iFrostizz iFrostizz

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[chain] Create a single Block object from StatefulBlock and StatelessBlock
2 participants
@iFrostizz @aaronbuchwald