Make store take a list of (key, value) to "store many"
#1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
requested changes
Jul 5, 2024
Comment on lines
71
to
81
| fn store_internal<V: BorshSerialize>( | ||
| cache: &mut RefMut<HashMap<K, Option<Vec<u8>>>>, | ||
| key: K, | ||
| value: &V, | ||
| ) -> Result<(), Error> { |
There was a problem hiding this comment.
This isn't a good pattern to follow if there's another way to do it.
iFrostizz
force-pushed
the
store_iter
branch
2 times, most recently
from
a08c10e
to
6ab3bc0
Compare
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org> Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>
richardpringle
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1096
Update
storeso that it takes a list of tuples, and create a newstore_singleto match the old behavior.The cache is not passed by mutable reference in order to avoid the runtime cost of borrowing it mutably many times.
The only pitfall is that because the function signature of
storeis nowfn store<V: BorshSerialize, Pairs: IntoIterator<Item = (K, &V)>, theVhas to be the same consistent type across the list.