Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement action test suite helper #1139
Implement action test suite helper #1139
Changes from 30 commits
9e53841
fb5d9a7
18ffdf2
f189b56
504df82
c07bca0
adcf1ae
48af784
566fff4
4f860f1
96a8d0a
900cf09
41c7e18
85b254b
5a11a97
5fc6d05
5dac07b
25f23e2
94c5cf0
0fe76f1
8e5bc5b
5b5ff1c
c31613d
5197db3
2bb3973
b3ed3b5
dbc4076
45383c3
8cd0738
c9c9dea
160137b
b2be701
3c266e6
9055d39
7b55c6f
86f8f46
ddd5084
658b810
0cf9190
c97b9b9
0286e57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could have modified the API such that these methods never return an error because all of them cannot really fail, in the case of
GetValue
then the check ofnil
could have just been used for the value but it's a bad idea for an API that tries to mimic other databases so it "simulates" errors.