Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Token Example #1142

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Updated Token Example #1142

merged 5 commits into from
Jul 16, 2024

Conversation

samliok
Copy link
Contributor

@samliok samliok commented Jul 15, 2024

A more robust token example, which will be used by the CFMM program.

@samliok samliok self-assigned this Jul 15, 2024
richardpringle
richardpringle requested changes Jul 15, 2024
View reviewed changes
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
iFrostizz
iFrostizz requested changes Jul 16, 2024
View reviewed changes
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated Show resolved Hide resolved
x/programs/rust/examples/token/src/lib.rs Outdated
Comment on lines 211 to 212
let total_allowance = if sender == actor {
_balance_of(program, actor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably doesn't really make sense to write this allowance afterwards. Doing a transfer_from if the sender is also the actor should be equivalent to a call to a transfer, without having the side-effect of changing the allowance (even though this allowance is only set from the actor to the actor, which is probably harmless)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think transfer_from should be no different if the sender is equal to the actor. I can see a couple use cases where the actor wants to enforce restrictions on their own tokens.

Removed the if statement.

@samliok samliok merged commit 2a85548 into main Jul 16, 2024
20 checks passed
iFrostizz pushed a commit that referenced this pull request Jul 18, 2024
@samliok @iFrostizz
Updated Token Example (#1142)
0fe76f1 
* token example

* StateKey -> StateKeys

* nits

* update asserts and unwraps
aaronbuchwald added a commit that referenced this pull request Jul 23, 2024
@iFrostizz @aaronbuchwald
@samliok @richardpringle @najeal @joshua-kim @ARR4N
Implement action test suite helper (#1139)
69ee367 
* implement action test suite helper

* add morpheusvm action tests

* add check for contains error for dynamic errors

* remove morpheusvm test, simplify suite

* add morpheusvm parametrized tests

* add licence

* check err

* cleanup

* remove `Actor` usage and implement `InMemoryStore`

* remove unused ctx

* add review suggestions

* Update chaintesting/action_test_helpers.go

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>

* Update chaintesting/action_test_helpers.go

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>

* add tests, set actor, add assertion

* Updated Token Example (#1142)

* token example

* StateKey -> StateKeys

* nits

* update asserts and unwraps

* Expose state functions from context (#1153)

* use `WindowSize` constant (#1155)

* update readme to point to an existing tokenvm action (#1049)

* update readme to point to an existing tokenvm action

* update readme: change action name

---------

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>

* Refactor `vm.Config` out of `vm.Controller` (#1146)

* refactor hypersdk config out of controllers

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>

* remove unused parallelism key from test configs (#1158)

Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>

* Remove `key_create` endpoint and use `Address` everywhere (#1121)

* pass directly actor address to simulator

* remove unused params

* Conditionally compile the `Address` helpers

* add test-utils flag

* Don't add unnecessary dependency (#1122)

* cleanup

* read `Actor` directly

* remove support for `create_key` endpoint and replace everything by
`Address` instances

* remove unused params

* remove `Key` `Param` (#1131)

* remove `Address::from_str`

---------

Co-authored-by: Richard Pringle <richard.pringle@avalabs.org>

* rename to chaintest, slice of `ActionTest`, remove suite

* rename to `InMemoryStore` to export type

* Update examples/morpheusvm/actions/transfer_test.go

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>

* add sender post-balance assertion

* pass in `*testing.T` to the `Assertion` func pointer

* pass context from `Run`, handle error signal on done

* Context plumbing in `ActionTest` suite (#1170)

* refactor: run tests individually to avoid `Context` pollution

* refactor: pipe `Contexts` where possible

The functions that are immediately run at declaration don't have a natural means of accepting a `Context` so can be considered the same as the `TestXXX()` entrypoint function.

* write helper function

* Update chaintest/action_test_helpers.go

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>

* Update examples/morpheusvm/actions/transfer_test.go

Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>

---------

Signed-off-by: Franfran <51274081+iFrostizz@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Co-authored-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org>
Co-authored-by: nathan haim <haim.nathan@icloud.com>
Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpringle richardpringle richardpringle approved these changes

@iFrostizz iFrostizz iFrostizz approved these changes

@dboehm-avalabs dboehm-avalabs Awaiting requested review from dboehm-avalabs dboehm-avalabs is a code owner

Assignees

@samliok samliok

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samliok @richardpringle @iFrostizz