Snow VM #1831
Merged
Snow VM #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
added
the
DO NOT MERGE
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Next steps:
Most importantly break this PR up |
aaronbuchwald
commented
Jan 10, 2025
Comment on lines
+56
to
+60
| res.Errors = make([]string, len(errs)) | ||
| for i, err := range errs { | ||
| if err != nil { | ||
| res.Errors[i] = err.Error() | ||
| } |
There was a problem hiding this comment.
Fixes a bug discovered in a newly added test. If the error was nil, then the previous code triggered a panic.
Comment on lines
+38
to
+40
| return fmt.Errorf("%w: tx timestamp (%d) < block timestamp (%d)", ErrTimestampTooLate, b.Timestamp, timestamp) | ||
| case b.Timestamp > timestamp+r.GetValidityWindow(): // tx: 100 block 10 | ||
| return ErrTimestampTooEarly | ||
| return fmt.Errorf("%w: tx timestamp (%d) > block timestamp (%d) + validity window (%d)", ErrTimestampTooEarly, b.Timestamp, timestamp, r.GetValidityWindow()) |
There was a problem hiding this comment.
Added details while debugging newly added tests. These errors are much more helpful with the added information.
| @@ -72,10 +71,8 @@ func (p *PreExecutor) PreExecute( | |||
| } | |||
|
|
|||
| // Verify auth if not already verified by caller | |||
| if verifyAuth { | |||
There was a problem hiding this comment.
This was never false previously.
Comment on lines
+157
to
+158
| // NewTransaction creates a Transaction and initializes the private fields. | ||
| func NewTransaction(base *Base, actions Actions, auth Auth) (*Transaction, error) { |
There was a problem hiding this comment.
Need this exported for newly added tests
aaronbuchwald
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the changes added in #1867.
The overall change separates implementing the AvalancheGo
block.VMandsnowman.Blockinterfaces to fulfill DynamicStateSync into a separate, independently tested package.This splits up the VM into individual pieces that can be overridden and creates a new
Chaininterface that can define three concrete block typesAdditionally,
ChainimplementsInitializeandSetConsensusIndexto take in all of the necessary parameters supplied by AvalancheGo and to set the required subscriptions or hooks needed to operate ie. accepted/verified/rejected block subscriptions, notifications when the VM transitions toNormalOp, etc.After integrating, this PR adds new integration action/auth agnostic integration tests for the updated VM package. This replaces the test coverage previously added through MorpheusVM and cuts down the MorpheusVM integration tests to only the tests written to run against
workload.TestNetwork.