Add benches for the merkle package #794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to speed this up if we want to merge this. 618s for 10k items seems really wrong or broken. |
merkle/merkle.go
Outdated
| }) | ||
| } | ||
|
|
||
| db, err := merkledb.New(ctx, memdb.New(), merkledb.Config{ |
There was a problem hiding this comment.
It is possible that memdb could be the cause of this.
I talked to @danlaine about writing a much thinner merkle wrapper just for this function (which shouldn't require caches/history/etc).
This reverts commit f009424. focus changes on the bench
| var db merkledb.MerkleDB | ||
| var err error | ||
|
|
||
| defaultConfig := merkledb.Config{ |
There was a problem hiding this comment.
I don't really want to merge this until this config is largely removed. We need a "single instance" trie that is merkleDB-compatible for #950
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #689 (comment)
This PR adds a bench to measure the time of generation of the merkle root of transactions.
We execute it for 10, 100, 1000, and 10000 iterations, here are the results:
The average time it takes per operation doesn't scale linearly which makes sense given the tree data-structure.