Fix logging on the simulator #873
Conversation
iFrostizz
requested review from
samliok,
dboehm-avalabs and
richardpringle
as code owners
| fileEnc := config.LogFormat.FileEncoder() | ||
|
|
||
| var consoleWriter io.WriteCloser | ||
| if config.DisableWriterDisplaying { | ||
| consoleWriter = newDiscardWriteCloser() | ||
| } else { | ||
| consoleWriter = os.Stdout | ||
| consoleWriter = os.Stderr |
There was a problem hiding this comment.
We use Stderr in order not to interfere with the plans being piped from Stdin. This is hopefully a temporary solution.
x/programs/cmd/simulator/cmd/root.go
Outdated
| // pre-execute the command to pre-parse flags | ||
| err := cmd.Execute() | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
Is this too hacky ? I haven't found a clean solution to pass a global flag to subcommands before the call to Execute (parsing)
There was a problem hiding this comment.
I would suggest to make a cmd.ParseFlags(os.Args[1:]) instead. This is cleaner in my opinion. What do you think?
There was a problem hiding this comment.
@najeal the issue is that this won't let us place the cli flag in another position than just after the call to the binary if I understand correctly
There was a problem hiding this comment.
I have read too fast, that's a good suggestion and I will add it thanks !
x/programs/cmd/simulator/cmd/root.go
Outdated
| // pre-execute the command to pre-parse flags | ||
| err := cmd.Execute() | ||
| if err != nil { | ||
| fmt.Fprintln(os.Stderr, err) | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
I would suggest to make a cmd.ParseFlags(os.Args[1:]) instead. This is cleaner in my opinion. What do you think?
iFrostizz
force-pushed
the
simulator_log_level
branch
from
24217d8
to
94b4b94
Compare
# This is the 1st commit message: fix logging # The commit message #2 will be skipped: # fix nits # The commit message #3 will be skipped: # set log level to error in the simulator client & write logs to Stderr # The commit message #4 will be skipped: # preparse flags with `ParseFlags` # The commit message #5 will be skipped: # fix logging # The commit message #6 will be skipped: # fix nits # The commit message #7 will be skipped: # set log level to error in the simulator client & write logs to Stderr # The commit message #8 will be skipped: # fix logging # The commit message #9 will be skipped: # fix nits # The commit message #10 will be skipped: # set log level to error in the simulator client & write logs to Stderr # The commit message #11 will be skipped: # preparse flags with `ParseFlags`
iFrostizz
force-pushed
the
simulator_log_level
branch
from
94b4b94
to
02c63bf
Compare
|
Closing because I'm currently rewriting that part anyway |
Closes #864, closes #850, closes #787
The logging on the simulator was broken. The issue is that the logging level which is passed to subcommands was done before the call to
ExecuteContext. We callExecuteand it's a bit hacky but there doesn't seem to be many very clean solutions. The logging can now be disabled using the new--log-disable-display-plugin-logsflag.