[WIP] ERC20 Token Program #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
30
to
35
| pub fn owner_check(program: &Program<StateKey>, actor: Address) { | ||
| assert!( | ||
| get_owner(program) == actor, | ||
| "caller is required to be owner" | ||
| ) | ||
| } |
There was a problem hiding this comment.
You could actually write an extension trait for the Context to call context.is_owner() directly.
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org> Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
Co-authored-by: Richard Pringle <richard.pringle@avalabs.org> Signed-off-by: David Boehm <91908103+dboehm-avalabs@users.noreply.github.com>
dboehm-avalabs
commented
May 28, 2024
dboehm-avalabs
commented
May 30, 2024
dboehm-avalabs
commented
May 30, 2024
| .expect("failed to get sender balance") | ||
| .unwrap_or_default(); | ||
|
|
||
| assert!(sender_balance >= amount, "invalid input"); |
There was a problem hiding this comment.
Is this the mechanism we want to be using for checking conditions?
There was a problem hiding this comment.
I think that we need to figure out #595
|
Is this PR doing what I think it is doing? If you are adding ERC20 to HyperSDK, that is such a sad thing for me to see. We have an opportunity to do something much better and ERC20 is a huge step backwards. |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.