Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /metrics endpoint and collect basic metrics #384

Closed
iansuvak opened this issue Jul 23, 2024 · 0 comments · Fixed by #398
Closed

Add /metrics endpoint and collect basic metrics #384

iansuvak opened this issue Jul 23, 2024 · 0 comments · Fixed by #398
Assignees
@feuGeneA
Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Milestone
Signature Aggrega...

Comments

@iansuvak
Copy link
Contributor

Context and scope
Initial metrics to be collected should be:

  • latency to fetch/construct signatures
  • cache hit/miss rate
  • request counts
  • network failures
  • empty signaure failures (node unwilling or unable to sign message)

Discussion and alternatives

Open questions
Are there any other metrics that we want to be collecting?
@iansuvak iansuvak added the enhancement New feature or request label Jul 23, 2024
@meaghanfitzgerald meaghanfitzgerald added the Warp Signature API API service for serving arbitrary Warp signatures from any VM label Jul 29, 2024
@feuGeneA feuGeneA self-assigned this Jul 30, 2024
feuGeneA added a commit that referenced this issue Aug 1, 2024
@feuGeneA
metrics for signature-aggregator
674770d 
fixes #384
@feuGeneA feuGeneA mentioned this issue Aug 1, 2024
Merged
feuGeneA added a commit that referenced this issue Aug 1, 2024
@feuGeneA
metrics for signature-aggregator
ea7fbae 
fixes #384
feuGeneA added a commit that referenced this issue Aug 1, 2024
@feuGeneA
metrics for signature-aggregator
0013040 
fixes #384
feuGeneA added a commit that referenced this issue Aug 1, 2024
@feuGeneA
metrics for signature-aggregator
40028cc 
fixes #384
feuGeneA added a commit that referenced this issue Aug 1, 2024
@feuGeneA
metrics for signature-aggregator
f1392e9 
fixes #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feuGeneA feuGeneA

Labels
enhancement New feature or request Warp Signature API API service for serving arbitrary Warp signatures from any VM
Projects
None yet
Milestone
Signature Aggregator API - MVP
Development

Successfully merging a pull request may close this issue.

metrics for signature-aggregator ava-labs/icm-services
3 participants
@iansuvak @feuGeneA @meaghanfitzgerald